[all-commits] [llvm/llvm-project] 7ae391: [flang]Fix incorrect array type transformation
Mats Petersson via All-commits
all-commits at lists.llvm.org
Thu Jul 28 13:00:29 PDT 2022
Author: Mats Petersson <mats.petersson at arm.com>
Date: 2022-07-28 (Thu, 28 Jul 2022)
[flang]Fix incorrect array type transformation
When an array is defined with "unknown" size, such as fir.array<2x?x5xi32>,
it should be converted to llvm.array<10 x i32>. The code so far has
been converting it to llvm.ptr<i32>.
Using a different function to check the if there starting are constant
dimensions, rather than if ALL dimensions are constant, it now produces
the correct array form.
Some tests has been updated, so they are now checking the new behaviour
rather than the old behaviour - so there's no need to add further tests
for this particular scenario.
This was originally found when compiling Spec 17 code, where an assert
in a GepOP was hit. That is bug #56141, which this change fixes.
Reviewed By: jeanPerier
Differential Revision: https://reviews.llvm.org/D129196
More information about the All-commits