[all-commits] [llvm/llvm-project] 52a385: [flang] Disable pipefail for tests for stdin input

David Spickett via All-commits all-commits at lists.llvm.org
Wed Jul 27 03:31:15 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 52a3855fe7ca106e675175cb8db87c1f57b2242a
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-07-27 (Wed, 27 Jul 2022)

  Changed paths:
    R flang/test/Driver/input-from-stdin-llvm.ll
    R flang/test/Driver/input-from-stdin.f90
    A flang/test/Driver/input-from-stdin/input-from-stdin-llvm.ll
    A flang/test/Driver/input-from-stdin/input-from-stdin.f90
    A flang/test/Driver/input-from-stdin/lit.local.cfg

  Log Message:
  [flang] Disable pipefail for tests for stdin input

We have seen the llvm test fail every so often on our bots:

This happens because `flang-new -fc1 -S` does not wait for the
pipe to finish being written to/does not read out all the content.
You can see this in the output, cat comes after flang:
+ /home/tcwg-buildbot/worker/flang-aarch64-release/build/bin/not /home/tcwg-buildbot/worker/flang-aarch64-release/build/bin/flang-new -fc1 -S - -o -
+ cat /home/tcwg-buildbot/worker/flang-aarch64-release/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll
error: Invalid input type - expecting a Fortran file

This means that cat gets SIGPIPE which causes it to exit with
code 141 and that's the final result due to pipefail.

flang isn't wrong to exit early (I think some modes of grep also do this)
and we only care about flang's exit code. So disable pipefail for
the stdin testing.

Reviewed By: awarzynski

Differential Revision: https://reviews.llvm.org/D130619

More information about the All-commits mailing list