[all-commits] [llvm/llvm-project] df344e: [JITLink][COFF] Implement IMAGE_COMDAT_SELECT_LARG...

[Sunho Kim via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: df344e1f44282848eefac252fbe1a7b4d6031430
      https://github.com/llvm/llvm-project/commit/df344e1f44282848eefac252fbe1a7b4d6031430
  Author: Sunho Kim <ksunhokim123 at gmail.com>
  Date:   2022-07-26 (Tue, 26 Jul 2022)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp
    M llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_largest.test

  Log Message:
  -----------
  [JITLink][COFF] Implement IMAGE_COMDAT_SELECT_LARGEST partially.

Implement IMAGE_COMDAT_SELECT_LARGEST partially. It's going to fail if larger symbol appears but this hasn't happened at least in vcruntime library.

We probably would not implement this properly as it requires complicated runtime patching which is not of nature of JIT. However, we'd like to validate if larger section appears and report to the user in the near future.

Reviewed By: lhames

Differential Revision: https://reviews.llvm.org/D129941