[all-commits] [llvm/llvm-project] 7f9e6f: [llvm][cmake] Make `install_symlink` workflow work...

John Ericson via All-commits all-commits at lists.llvm.org
Mon Jul 25 20:14:59 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f9e6f6fa6547b9c5648d96fd96920467c8b3e84
  Author: John Ericson <John.Ericson at Obsidian.Systems>
  Date:   2022-07-26 (Tue, 26 Jul 2022)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake
    M llvm/cmake/modules/LLVMInstallSymlink.cmake

  Log Message:
  [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs

If `CMAKE_INSTALL_BINDIR` is a different absolute path per project, as
it is with NixOS when we install every package to its own prefix, the
old way fails when the absolute path gets prepended with `CMAKE_INSTALL_PREFIX`.

The `extend_path` function does what we want, but it is currently internal-only. So easier to just inline the one small case of it we need.

Also fix one stray `bin` -> `CMAKE_INSTALL_BINDIR`

Reviewed By: sebastian-ne

Differential Revision: https://reviews.llvm.org/D101070

More information about the All-commits mailing list