[all-commits] [llvm/llvm-project] c7ea20: [ORC][COFF] Properly set weak flag to COMDAT symbols.

Sunho Kim via All-commits all-commits at lists.llvm.org
Mon Jul 25 07:25:55 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c7ea209068a7f0bcc84629ece24274db06c61878
  Author: Sunho Kim <ksunhokim123 at gmail.com>
  Date:   2022-07-25 (Mon, 25 Jul 2022)

  Changed paths:
    M llvm/lib/ExecutionEngine/Orc/ObjectFileInterface.cpp
    A llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_weak_duplicate.s
    A llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_weak_plus_strong.s
    A llvm/test/ExecutionEngine/JITLink/X86/COFF_strong_duplicate.s
    A llvm/test/ExecutionEngine/JITLink/X86/Inputs/COFF_comdat_weak_def.yaml
    A llvm/test/ExecutionEngine/JITLink/X86/Inputs/COFF_strong_def.yaml

  Log Message:
  [ORC][COFF] Properly set weak flag to COMDAT symbols.

Properly set weak flag to COMDAT symbols so that no duplicate definition error will be generated. There is an inaccuracy in setting plain weak for largest selection type, which will be dealt with soon when largest type is properly implemented.

Reviewed By: lhames

Differential Revision: https://reviews.llvm.org/D129764

More information about the All-commits mailing list