[all-commits] [llvm/llvm-project] 59179d: [Sema] Merge C++20 concept definitions from differ...
Ilya Biryukov via All-commits
all-commits at lists.llvm.org
Mon Jul 25 05:53:12 PDT 2022
Author: Ilya Biryukov <ibiryukov at google.com>
Date: 2022-07-25 (Mon, 25 Jul 2022)
[Sema] Merge C++20 concept definitions from different modules in same TU
Currently the C++20 concepts are only merged in `ASTReader`, i.e. when
coming from different TU. This can causes ambiguious reference errors when
trying to access the same concept that should otherwise be merged.
Please see the added test for an example.
Note that we currently use `ASTContext::isSameEntity` to check for ODR
violations. However, it will not check that concept requirements match.
The same issue holds for mering concepts from different TUs, I added a
FIXME and filed a GH issue to track this:
Reviewed By: ChuanqiXu
Differential Revision: https://reviews.llvm.org/D128921
More information about the All-commits