[all-commits] [llvm/llvm-project] dc850f: [AMDGPU] NFC. Assert that mask is full with VOPC DPP

Joe Nash via All-commits all-commits at lists.llvm.org
Wed Jul 20 10:53:20 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc850fbf3ba9e3fa6f805c3e58dcb87619ad4fdf
      https://github.com/llvm/llvm-project/commit/dc850fbf3ba9e3fa6f805c3e58dcb87619ad4fdf
  Author: Joe Nash <Joseph.Nash at amd.com>
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
    M llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp
    M llvm/test/CodeGen/AMDGPU/vopc_dpp.mir

  Log Message:
  -----------
  [AMDGPU] NFC. Assert that mask is full with VOPC DPP

VOPC DPP should not be formed when the row_mask and bank_mask are not
0xf (full) because the resulting VOP DPP would have different semantics
than the MOV DPP followed by VOP. Existing checks in GCNDPPCombine cover
this case but for different reasons, so assert the property for
future-proofing.

Reviewed By: nhaehnle

Differential Revision: https://reviews.llvm.org/D130101




More information about the All-commits mailing list