[all-commits] [llvm/llvm-project] 5a4033: update-test-checks: safely handle tests with #if's

Nicolai Hähnle via All-commits all-commits at lists.llvm.org
Wed Jul 20 02:24:19 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5a4033c36716de0cee75eb28b95cce44ae239cd9
      https://github.com/llvm/llvm-project/commit/5a4033c36716de0cee75eb28b95cce44ae239cd9
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
    A clang/test/utils/update_cc_test_checks/Inputs/ifdef.c
    A clang/test/utils/update_cc_test_checks/Inputs/ifdef.c.expected
    A clang/test/utils/update_cc_test_checks/ifdef.test
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll
    M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll.expected
    M llvm/utils/UpdateTestChecks/asm.py
    M llvm/utils/UpdateTestChecks/common.py
    M llvm/utils/update_analyze_test_checks.py
    M llvm/utils/update_cc_test_checks.py
    M llvm/utils/update_llc_test_checks.py
    M llvm/utils/update_test_checks.py

  Log Message:
  -----------
  update-test-checks: safely handle tests with #if's

There is at least one Clang test (clang/test/CodeGen/arm_acle.c) which
has functions guarded by #if's that cause those functions to be compiled
only for a subset of RUN lines.

This results in a case where one RUN line has a body for the function
and another doesn't. Treat this case as a conflict for any prefixes that
the two RUN lines have in common.

This change exposed a bug where functions with '$' in the name weren't
properly recognized in ARM assembly (despite there being a test case
that was supposed to catch the problem!). This bug is fixed as well.

Differential Revision: https://reviews.llvm.org/D130089




More information about the All-commits mailing list