[all-commits] [llvm/llvm-project] f69387: [ODRHash diagnostics] Preparation to minimize subs...

Volodymyr Sapsai via All-commits all-commits at lists.llvm.org
Tue Jul 19 16:29:57 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f693874c53c1b3d3a322de98c1c7557d69157d3d
      https://github.com/llvm/llvm-project/commit/f693874c53c1b3d3a322de98c1c7557d69157d3d
  Author: Volodymyr Sapsai <vsapsai at apple.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

Specifically, making the following changes:
* Turn lambdas calculating ODR hashes into static functions.
* Move `ODRCXXRecordDifference` where it is used.
* Rename some variables and move some lines of code.
* Replace `auto` with explicit type when the deduced type is not mentioned.
* Add `const` for unmodified objects, so we can pass them to more functions.

Differential Revision: https://reviews.llvm.org/D128690




More information about the All-commits mailing list