[all-commits] [llvm/llvm-project] f6017a: [lld-macho] Support folding of functions with iden...

Jez Ng via All-commits all-commits at lists.llvm.org
Tue Jul 19 10:30:34 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f6017abb602780d81be928c93ec6afe74752f613
      https://github.com/llvm/llvm-project/commit/f6017abb602780d81be928c93ec6afe74752f613
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M lld/MachO/ICF.cpp
    M lld/MachO/InputFiles.cpp
    M lld/MachO/InputSection.cpp
    M lld/MachO/InputSection.h
    M lld/test/MachO/icf.s

  Log Message:
  -----------
  [lld-macho] Support folding of functions with identical LSDAs

To do this, we need to slice away the LSDA pointer, just like we are
slicing away the functionAddress pointer.

No observable difference in perf on chromium_framework:

             base           diff           difference (95% CI)
  sys_time   1.769 ± 0.068  1.761 ± 0.065  [  -2.7% ..   +1.8%]
  user_time  9.517 ± 0.110  9.528 ± 0.116  [  -0.6% ..   +0.8%]
  wall_time  8.291 ± 0.174  8.307 ± 0.183  [  -1.1% ..   +1.5%]
  samples    21             25

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D129830




More information about the All-commits mailing list