[all-commits] [llvm/llvm-project] 5d1487: [llvm][AArch64] Add missing FPCR, H and B register...

David Spickett via All-commits all-commits at lists.llvm.org
Tue Jul 19 02:33:35 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d1487324947e47a6ef06553ed962485c39387c3
      https://github.com/llvm/llvm-project/commit/5d1487324947e47a6ef06553ed962485c39387c3
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M llvm/include/llvm/DebugInfo/CodeView/CodeViewRegisters.def
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
    A llvm/test/DebugInfo/COFF/AArch64/codeview-b-register.mir
    A llvm/test/DebugInfo/COFF/AArch64/codeview-h-register.mir

  Log Message:
  -----------
  [llvm][AArch64] Add missing FPCR, H and B registers to Codeview mapping

Fixes https://github.com/llvm/llvm-project/issues/56484

H registers are 16 bit views of AArch64's Neon registers and
B are the 8 bit views.

msvc does not support 16 bit float (some mention in DirectX but I
couldn't find a way to get to it) so for lack of a better reference
I'm using:
https://github.com/MicrosoftEdge/JsDbg/blob/85c9b41b33bb8f3496dbe400d912c32bb7cc496b/server/references/dia/include/cvconst.h
(the other microsoft-pdb repo is no longer up to date)

Luckily clang does support fp16 so a test is added for that.

There is no 8 bit float type so I had to get creative with the
test case. We're not testing for correct debug info here just
that we can select the B register and not crash in the process.

For FPCR it's never going to be passed as an argument so I've
not added a test for it. It is included to keep our list looking
the same as the reference.

Reviewed By: majnemer

Differential Revision: https://reviews.llvm.org/D129774




More information about the All-commits mailing list