[all-commits] [llvm/llvm-project] a2ac38: [llvm] Fix forward declaration in Support/JSON.h

serge-sans-paille via All-commits all-commits at lists.llvm.org
Tue Jul 19 00:08:03 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a2ac383b44172ec47e4086d7572597ab251a4793
      https://github.com/llvm/llvm-project/commit/a2ac383b44172ec47e4086d7572597ab251a4793
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M llvm/include/llvm/Support/JSON.h

  Log Message:
  -----------
  [llvm] Fix forward declaration in Support/JSON.h

Some methods of json::Array require json::Value to be completely defined, so
they can't be defined in-class. Fix that by defining them out of class.

Fix #55780


  Commit: eb0e3319bf94934b09f7b67ca09606dad55bf24f
      https://github.com/llvm/llvm-project/commit/eb0e3319bf94934b09f7b67ca09606dad55bf24f
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cpp

  Log Message:
  -----------
  [sanitizer] Don't call dlerror() after swift_demangle lookup through dlsym

Because the call to `dlerror()` may actually want to print something, which turns into a deadlock
as showcased in #49223.

Instead rely on further call to dlsym to clear `dlerror` internal state if they
need to check the return status.

Differential Revision: https://reviews.llvm.org/D128992


Compare: https://github.com/llvm/llvm-project/compare/af09127c94e5...eb0e3319bf94


More information about the All-commits mailing list