[all-commits] [llvm/llvm-project] fe47cf: [lld-macho][nfc] Add more tests + comments around ...

Jez Ng via All-commits all-commits at lists.llvm.org
Fri Jul 15 21:53:05 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fe47cfb324cbc761741527230dc7436ecf62f8c6
      https://github.com/llvm/llvm-project/commit/fe47cfb324cbc761741527230dc7436ecf62f8c6
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-07-16 (Sat, 16 Jul 2022)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M lld/test/MachO/icf.s

  Log Message:
  -----------
  [lld-macho][nfc] Add more tests + comments around ICF + unwind info interaction

While working on {D129830}, I realized that our handling of ICF +
eh_frame combined was untested. Additionally I realized that the comment
explaining why we were safely slicing away the functionAddress reloc
from our compact unwind entries was... insufficient and slightly
misleading. I've tried to clarify it.

Reviewed By: #lld-macho, thevinster

Differential Revision: https://reviews.llvm.org/D129894




More information about the All-commits mailing list