[all-commits] [llvm/llvm-project] 2659e1: [SCEV] List all binops in getOperandsToCreate()

Nikita Popov via All-commits all-commits at lists.llvm.org
Fri Jul 15 08:09:03 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2659e1bf4b54cf9c2fadac0813e5e0ab4d2c49d5
      https://github.com/llvm/llvm-project/commit/2659e1bf4b54cf9c2fadac0813e5e0ab4d2c49d5
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-07-15 (Fri, 15 Jul 2022)

  Changed paths:
    M llvm/lib/Analysis/ScalarEvolution.cpp

  Log Message:
  -----------
  [SCEV] List all binops in getOperandsToCreate()

Explicitly list all binops rather than having a default case. There
were two bugs here:
1. U->getOpcode() was used instead of BO->Opcode, which means we
   used the logic for the wrong opcode in some cases.
2. SCEV construction does not support LShr. We should return
   unknown for it rather than recursing into the operands.




More information about the All-commits mailing list