[all-commits] [llvm/llvm-project] ac49e9: jGetLoadedDynamicLibrariesInfos can inspect machos...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ac49e9021919d2a356dd10b39888f168736a43b0
      https://github.com/llvm/llvm-project/commit/ac49e9021919d2a356dd10b39888f168736a43b0
  Author: Jason Molenda <jason at molenda.com>
  Date:   2022-07-14 (Thu, 14 Jul 2022)

  Changed paths:
    A lldb/test/API/macosx/unregistered-macho/Makefile
    A lldb/test/API/macosx/unregistered-macho/TestUnregisteredMacho.py
    A lldb/test/API/macosx/unregistered-macho/main.c
    M lldb/tools/debugserver/source/MacOSX/MachProcess.h
    M lldb/tools/debugserver/source/MacOSX/MachProcess.mm

  Log Message:
  -----------
  jGetLoadedDynamicLibrariesInfos can inspect machos not yet loaded

jGetLoadedDynamicLibrariesInfos normally checks with dyld to find
the list of binaries loaded in the inferior, and getting the filepath,
before trying to parse the Mach-O binary in inferior memory.
This allows for debugserver to parse a Mach-O binary present in memory,
but not yet registered with dyld.  This patch also adds some simple
sanity checks that we're reading a Mach-O header before we begin
stepping through load commands, because we won't have the sanity check
of consulting dyld for the list of loaded binaries before parsing.
Also adds a testcase.

[This patch was reverted after causing a testsuite failure on a CI bot;
I haven't been able to repro the failure outside the CI, but I have a
theory that my sanity check on cputype which only matched arm64 and
x86_64 - and the CI machine may have a watch simulator that is still
using i386.]

Differential Revision: https://reviews.llvm.org/D128956
rdar://95737734