[all-commits] [llvm/llvm-project] db73a5: [trace][intel pt] Add a nice parser for the trace ...

walter erquinigo via All-commits all-commits at lists.llvm.org
Wed Jul 13 10:53:31 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: db73a52d7b19249670c9cf169c0535b36f388496
      https://github.com/llvm/llvm-project/commit/db73a52d7b19249670c9cf169c0535b36f388496
  Author: rnofenko <rnofenko at fb.com>
  Date:   2022-07-13 (Wed, 13 Jul 2022)

  Changed paths:
    M lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp
    M lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.h
    M lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
    M lldb/source/Plugins/Trace/intel-pt/TraceIntelPTOptions.td
    M lldb/test/API/commands/trace/TestTraceStartStop.py

  Log Message:
  -----------
  [trace][intel pt] Add a nice parser for the trace size

Thanks to rnofenko at fb.com for coming up with these changes.

This diff adds support for passing units in the trace size inputs. For example,
it's now possible to specify 64KB as the trace size, instead of the
problematic 65536. This makes the user experience a bit friendlier.

Differential Revision: https://reviews.llvm.org/D129613




More information about the All-commits mailing list