[all-commits] [llvm/llvm-project] d6ef3d: [mlir] Remove VectorToROCDL

[Krzysztof Drewniak via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d6ef3d20b4e3768dc30fb229dfa938d8059fffef
      https://github.com/llvm/llvm-project/commit/d6ef3d20b4e3768dc30fb229dfa938d8059fffef
  Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
  Date:   2022-07-12 (Tue, 12 Jul 2022)

  Changed paths:
    M clang/docs/ClangFormattedStatus.rst
    M clang/docs/tools/clang-formatted-files.txt
    M mlir/include/mlir/Conversion/Passes.h
    M mlir/include/mlir/Conversion/Passes.td
    R mlir/include/mlir/Conversion/VectorToROCDL/VectorToROCDL.h
    M mlir/lib/Conversion/CMakeLists.txt
    M mlir/lib/Conversion/GPUToROCDL/CMakeLists.txt
    M mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
    R mlir/lib/Conversion/VectorToROCDL/CMakeLists.txt
    R mlir/lib/Conversion/VectorToROCDL/VectorToROCDL.cpp
    R mlir/test/Conversion/VectorToROCDL/vector-to-rocdl.mlir
    M mlir/test/Integration/GPU/ROCM/vector-transferops.mlir
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  [mlir] Remove VectorToROCDL

Between issues such as
https://github.com/llvm/llvm-project/issues/56323, the fact that this
lowering (unlike the code in amdgpu-to-rocdl) does not correctly set
up bounds checks (and thus will cause page faults on reads that might
need to be padded instead), and that fixing these problems would,
essentially, involve replicating amdgpu-to-rocdl, remove
--vector-to-rocdl for being broken. In addition, the lowering does not
support many aspects of transfer_{read,write}, like supervectors, and
may not work correctly in their presence.

We (the MLIR-based convolution generator at AMD) do not use this
conversion pass, nor are we aware of any other clients.

Migration strategies:
- Use VectorToLLVM
- If buffer ops are particularly needed in your application, use
amdgpu.raw_buffer_{load,store}

A VectorToAMDGPU pass may be introduced in the future.

Reviewed By: ThomasRaoux

Differential Revision: https://reviews.llvm.org/D129308