[all-commits] [llvm/llvm-project] f3939d: [mlgo] Simplify autogenerated regalloc model

Aiden Grossman via All-commits all-commits at lists.llvm.org
Mon Jul 11 13:24:41 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f3939dc5093826c05f2a78ce1b0af769cd48fdab
      https://github.com/llvm/llvm-project/commit/f3939dc5093826c05f2a78ce1b0af769cd48fdab
  Author: Aiden Grossman <agrossman154 at yahoo.com>
  Date:   2022-07-11 (Mon, 11 Jul 2022)

  Changed paths:
    M llvm/lib/Analysis/models/gen-regalloc-eviction-test-model.py

  Log Message:
  -----------
  [mlgo] Simplify autogenerated regalloc model

Currently the autogenerated regalloc model will sometimes
output an incorrect LR index to evict instead of the first LR
with with the mask set to 1. This trips an assertion within
the MLRegallocAdvisor that the evicted LR has a mask of 1. This
patch, made possible by https://reviews.llvm.org/D124565, simplifies
the autogenerated model by taking away all unnecessary features and
getting rid of the functions that were previously to mix in all
the necessary inputs so they wouldn't get pruned by the Tensorflow
XLA AOT compiler. This is no longer necessary after the previously
mentioned patch. This also fixes the nondeterministic behavior
that is sometimes observed where the autogenerated model will
simply output 0 instead of the correct index.

Reviewed By: yundiqian

Differential Revision: https://reviews.llvm.org/D129254




More information about the All-commits mailing list