[all-commits] [llvm/llvm-project] 60450f: [RISCV] Add test cases for inline memcpy expansion

Craig Topper via All-commits all-commits at lists.llvm.org
Sun Jul 10 14:23:48 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 60450f91c8a622bdf93f68b66bf6139ac8cafa04
      https://github.com/llvm/llvm-project/commit/60450f91c8a622bdf93f68b66bf6139ac8cafa04
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-07-10 (Sun, 10 Jul 2022)

  Changed paths:
    A llvm/test/CodeGen/RISCV/memcpy-inline.ll

  Log Message:
  -----------
  [RISCV] Add test cases for inline memcpy expansion

Test file was taken directly from AArch64/ARM. I've added RUN
lines for aligned and unaligned since many of the test cases
are strings that aren't aligned and have an odd size.

Some of these test cases are modified by D129402.

Differential Revision: https://reviews.llvm.org/D129403


  Commit: 35ec8a423d46b2b81eb87ff74789f4d90d7bb00b
      https://github.com/llvm/llvm-project/commit/35ec8a423d46b2b81eb87ff74789f4d90d7bb00b
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-07-10 (Sun, 10 Jul 2022)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp
    M llvm/lib/Target/RISCV/RISCVISelLowering.h
    M llvm/test/CodeGen/RISCV/memcpy-inline.ll

  Log Message:
  -----------
  [RISCV] Teach shouldConvertConstantLoadToIntImm that constant materialization can use constant pools.

I think it only makes sense to return true here if we aren't going
to turn around and create a constant pool for the immmediate.

I left out the check for useConstantPoolForLargeInts() thinking
that even if you don't want the commpiler to create a constant pool
you might still want to avoid materializing an integer that is
already available in a global variable.

Test file was copied from AArch64/ARM and has not been commited yet.
Will post separate review for that.

Reviewed By: luismarques

Differential Revision: https://reviews.llvm.org/D129402


Compare: https://github.com/llvm/llvm-project/compare/28b41237e6b2...35ec8a423d46


More information about the All-commits mailing list