[all-commits] [llvm/llvm-project] c4ccf6: ManagedStatic: remove from GDBRegistrationListener

Nicolai Hähnle via All-commits all-commits at lists.llvm.org
Sun Jul 10 05:13:48 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c4ccf608c2380796d64db108eed3b24c1b0140ef
      https://github.com/llvm/llvm-project/commit/c4ccf608c2380796d64db108eed3b24c1b0140ef
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2022-07-10 (Sun, 10 Jul 2022)

  Changed paths:
    M llvm/lib/ExecutionEngine/GDBRegistrationListener.cpp

  Log Message:
  -----------
  ManagedStatic: remove from GDBRegistrationListener

An earlier version of this change originally landed as part of
e6f1f062457c928c18a88c612f39d9e168f65a85 (D129120), which caused a
Fuchsia buildbot regression in ExecutionEngine tests.

Careful review suggests that the issue was that in the earlier version,
the destructor of the JITDebugLock was run before the destructor of
GDBJITRegistrationListener. The new version of the change moves the lock
to a member variable of the (singleton!) GDBJITRegistartionListener so
that destructors are run in the right order.




More information about the All-commits mailing list