[all-commits] [llvm/llvm-project] 86a2f2: [Support] Fix Windows dump file hang with multi-th...

[Andrew Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 86a2f2e2db2aa9df39f38b59b238b21ec7229b02
      https://github.com/llvm/llvm-project/commit/86a2f2e2db2aa9df39f38b59b238b21ec7229b02
  Author: Andrew Ng <andrew.ng at sony.com>
  Date:   2022-07-08 (Fri, 08 Jul 2022)

  Changed paths:
    M llvm/lib/Support/Windows/Signals.inc

  Log Message:
  -----------
  [Support] Fix Windows dump file hang with multi-threaded crashes

Prevents deadlock between MiniDumpWriteDump and
CryptAcquireContextW (called via fs::createTemporaryFile) in
WriteWindowsDumpFile.

However, there's no guarantee that deadlock can't still occur between
MiniDumpWriteDump and some other Win32 API call. But that would appear
to be the "accepted" risk of using MiniDumpWriteDump in this manner.

Differential Revision: https://reviews.llvm.org/D129004