[all-commits] [llvm/llvm-project] 534a2b: [TableGen] Rewrite type set intersection in type i...

Krzysztof Parzyszek via All-commits all-commits at lists.llvm.org
Thu Jul 7 12:49:52 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 534a2bf99e7cce4ea71dca6f91997794e3a36587
      https://github.com/llvm/llvm-project/commit/534a2bf99e7cce4ea71dca6f91997794e3a36587
  Author: Krzysztof Parzyszek <kparzysz at quicinc.com>
  Date:   2022-07-07 (Thu, 07 Jul 2022)

  Changed paths:
    M llvm/utils/TableGen/CodeGenDAGPatterns.cpp

  Log Message:
  -----------
  [TableGen] Rewrite type set intersection in type inference

The previous code had a bug when dealing with matching iPTR against a
set of integer types. It was trying to handle it all in a compact way,
but that implementation couldn't be modified to correct the problem in
a simple way. The code wasn't long, and it was easier to rewrite it.

The actual issue was that non-scalar-integer types were considered when
matching against iPTR. For example {iPTR} intersected with {i32 f32}
was {iPTR} (due to multiple types in the other set), but should be just
{i32}, because i32 is the only integer scalar in the other set.




More information about the All-commits mailing list