[all-commits] [llvm/llvm-project] c0db2b: [mlir][tblgen] Reverting fatality of assemblyForma...

[wren romano via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c0db2b75ac1c0ff4299adcf2c6781a1775a28bfb
      https://github.com/llvm/llvm-project/commit/c0db2b75ac1c0ff4299adcf2c6781a1775a28bfb
  Author: wren romano <2998727+wrengr at users.noreply.github.com>
  Date:   2022-07-06 (Wed, 06 Jul 2022)

  Changed paths:
    M mlir/lib/TableGen/AttrOrTypeDef.cpp

  Log Message:
  -----------
  [mlir][tblgen] Reverting fatality of assemblyFormat with skipDefaultBuilders=1

Per @rriddle, we do not want to require `skipDefaultBuilders=0` per se; that is, even though the `assemblyFormat`-generated parser requires a builder with the same prototype as the default-builder, that prototype could instead be implemented via custom `builders`.  This differential reduces the FatalError introduced in D128555 to a non-fatal Warning instead, so that users can still be informed of the error condition (rather than waiting for the C++ compiler to fail).

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D129234