[all-commits] [llvm/llvm-project] 4270c9: [lldb] Stop passing both i386 and i686 in parallel...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4270c9cd44f2703bc5376ff085d0add156af9080
      https://github.com/llvm/llvm-project/commit/4270c9cd44f2703bc5376ff085d0add156af9080
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-07-06 (Wed, 06 Jul 2022)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp
    M lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
    M lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
    M lldb/test/Shell/ObjectFile/PECOFF/settings-abi-i686.yaml

  Log Message:
  -----------
  [lldb] Stop passing both i386 and i686 in parallel as architectures on Windows

When an object file returns multiple architectures, it is treated
as a fat binary - which really isn't the case of i386 vs i686 where
the object file actually has one architecture.

This allows getting rid of hardcoded architecture triples in
PlatformWindows.

The parallel i386 and i686 architecture strings stem from
5e6f45201f0b62c1e7a24fc396f3ea6e10dc880d / D7120 and
ad587ae4ca143d388c0ec4ef2faa1b5eddedbf67 / D4658.

Differential Revision: https://reviews.llvm.org/D128617