[all-commits] [llvm/llvm-project] ea8b81: [lldb/Core] Fix finite progress event reporting
Med Ismail Bennani via All-commits
all-commits at lists.llvm.org
Tue Jul 5 16:26:01 PDT 2022
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: ea8b811bf800680e7d7bde1e8d6ff43f8ecf17cf
https://github.com/llvm/llvm-project/commit/ea8b811bf800680e7d7bde1e8d6ff43f8ecf17cf
Author: Med Ismail Bennani <medismail.bennani at gmail.com>
Date: 2022-07-05 (Tue, 05 Jul 2022)
Changed paths:
M lldb/source/Core/Debugger.cpp
Log Message:
-----------
[lldb/Core] Fix finite progress event reporting
This patch should fix event handling for finite progress reports.
Previously, the event handler would get stuck when receiving a finite
progress report, and stop displaying upcoming reports.
This was due to the fact that we were checking if the progress event was
completed by calling `GetCompleted` but returns the completion amount
instead of saying whether it's completed.
That caused the current event id to remain the same, preventing all the
following progress reports to be shown to the user.
This patch also adds some logging to facilitate debugging progress events.
rdar://91788326
Differential Revision: https://reviews.llvm.org/D128768
Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>
More information about the All-commits
mailing list