[all-commits] [llvm/llvm-project] 4905bc: [ConstantFolding] Check return value of ConstantFo...

Nikita Popov via All-commits all-commits at lists.llvm.org
Mon Jul 4 05:20:17 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4905bcac00e6588bc82e51973dcac7b7a5361c94
      https://github.com/llvm/llvm-project/commit/4905bcac00e6588bc82e51973dcac7b7a5361c94
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-07-04 (Mon, 04 Jul 2022)

  Changed paths:
    M llvm/lib/Analysis/ConstantFolding.cpp

  Log Message:
  -----------
  [ConstantFolding] Check return value of ConstantFoldInstOperandsImpl()

This operation is fallible, but ConstantFoldConstantImpl() is not.
If we fail to fold, we should simply return the original expression.

I don't think this can cause any issues right now, but it becomes
a problem if once make ConstantFoldInstOperandsImpl() not create a
constant expression for everything it possibly could.




More information about the All-commits mailing list