[all-commits] [llvm/llvm-project] ccf7dd: [llvm-objdump] Ensure offloading sections have pro...

Joseph Huber via All-commits all-commits at lists.llvm.org
Fri Jul 1 20:27:14 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ccf7dd5e813dd066d720cbd7f70c9052a3a17e96
      https://github.com/llvm/llvm-project/commit/ccf7dd5e813dd066d720cbd7f70c9052a3a17e96
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2022-07-01 (Fri, 01 Jul 2022)

  Changed paths:
    M llvm/lib/Object/OffloadBinary.cpp
    M llvm/test/tools/llvm-objdump/Offloading/binary.test
    M llvm/test/tools/llvm-objdump/Offloading/warning.test

  Log Message:
  -----------
  [llvm-objdump] Ensure offloading sections have proper alignment

Summary:
A previous patch added support for dumping offloading sections. The
tests for this feature added dummy input to the required section using
`llvm-objcopy`. This binary format has a required alignment of `8` which
was not being respected by the file copied with llvm-objcopy and would
cause failures on architectures sensitive to alignment problems or with
sanitizers. This patch adds the proper alignemnt and adds an error check
at least for the binary format so it's not completely opaque. This
should be improvbed so users actually get a helpful message.




More information about the All-commits mailing list