[all-commits] [llvm/llvm-project] feb4b6: [InstCombine] avoid 'tmp' usage in test files; NFC

[Sanjay Patel via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: feb4b628ac0901f9bd8925b580adc55244c2d694
      https://github.com/llvm/llvm-project/commit/feb4b628ac0901f9bd8925b580adc55244c2d694
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-07-01 (Fri, 01 Jul 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/select-of-bittest.ll

  Log Message:
  -----------
  [InstCombine] avoid 'tmp' usage in test files; NFC

The update script ( utils/update_test_checks.py ) warns against this.


  Commit: 9c8a39c67b599b047510b181383a44547b2eead4
      https://github.com/llvm/llvm-project/commit/9c8a39c67b599b047510b181383a44547b2eead4
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-07-01 (Fri, 01 Jul 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
    M llvm/test/Transforms/InstCombine/select-of-bittest.ll

  Log Message:
  -----------
  [InstCombine] restrict select of bit-tests to constant shift amounts

This transform is responsible for a long-standing miscompile
as discussed in issue #47012 (was bugzilla #47668).

There was a proposal to correct it in D88432, but that was
abandoned and there hasn't been any recent activity to fix
it AFAICT.

The original patch D45108 started with a constant-shift-only
restriction and only expanded during review, so I don't think
there's much risk of perf regression on the motivating code.


Compare: https://github.com/llvm/llvm-project/compare/875ee0ed1c5a...9c8a39c67b59