[all-commits] [llvm/llvm-project] 540a76: [flang] Convert assertion to a TODO

Valentin Clement (バレンタイン クレメン) via All-commits all-commits at lists.llvm.org
Thu Jun 30 06:46:43 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 540a76f07483bc202f48c01477e6efc87c79f7a5
      https://github.com/llvm/llvm-project/commit/540a76f07483bc202f48c01477e6efc87c79f7a5
  Author: Valentin Clement <clementval at gmail.com>
  Date:   2022-06-30 (Thu, 30 Jun 2022)

  Changed paths:
    M flang/lib/Lower/IntrinsicCall.cpp

  Log Message:
  -----------
  [flang] Convert assertion to a TODO

The original assertion is not necessarily correct since the shape
argument may involve a slice of an array (an expression) and not a whole
vector with constant length. In the presence of a slice operation, the
size must be computed (left as a TODO for now).

This patch is part of the upstreaming effort from fir-dev branch.

Reviewed By: jeanPerier

Differential Revision: https://reviews.llvm.org/D128894

Co-authored-by: Eric Schweitz <eschweitz at nvidia.com>




More information about the All-commits mailing list