[all-commits] [llvm/llvm-project] 007934: [libTooling][NFC] Add a comment about comment pars...

Aaron Jacobs via All-commits all-commits at lists.llvm.org
Thu Jun 30 05:47:26 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 007934343c4c18102b2b3e4195d356dbcdf9a3fc
      https://github.com/llvm/llvm-project/commit/007934343c4c18102b2b3e4195d356dbcdf9a3fc
  Author: Aaron Jacobs <jacobsa at google.com>
  Date:   2022-06-30 (Thu, 30 Jun 2022)

  Changed paths:
    M clang/include/clang/Tooling/Transformer/SourceCode.h

  Log Message:
  -----------
  [libTooling][NFC] Add a comment about comment parsing to getAssociatedRange.

It took me multiple hours of debugging plus asking an expert for help to
figure out why this function didn't do what it promised to do. It turns
out there is a flag that needs to be set. Document this, in an attempt
to save the next person the surprise.

Reviewed By: ymandel

Differential Revision: https://reviews.llvm.org/D128774




More information about the All-commits mailing list