[all-commits] [llvm/llvm-project] 017c06: [ODRHash diagnostics] Move repetetive code at lamb...

Volodymyr Sapsai via All-commits all-commits at lists.llvm.org
Wed Jun 29 13:25:43 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 017c068f7899b895e654c8efc1c4d02d940dbf8a
      https://github.com/llvm/llvm-project/commit/017c068f7899b895e654c8efc1c4d02d940dbf8a
  Author: Volodymyr Sapsai <vsapsai at apple.com>
  Date:   2022-06-29 (Wed, 29 Jun 2022)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

It helps to avoid copy-paste mistakes and makes custom code paths more
noticeable.

Not funnelling all diagnostic through `ODRDiagDeclError` because plan to
break down `err_module_odr_violation_mismatch_decl_diff` into smaller
pieces instead of making it bigger and bigger.

Differential Revision: https://reviews.llvm.org/D128487




More information about the All-commits mailing list