[all-commits] [llvm/llvm-project] 2adaca: [clang][dataflow] Use diagnosis API in optional ch...

[Sam Estep via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2adaca532df4d3d7ae4cd3b724b2099ffefe235c
      https://github.com/llvm/llvm-project/commit/2adaca532df4d3d7ae4cd3b724b2099ffefe235c
  Author: Sam Estep <sam at samestep.com>
  Date:   2022-06-29 (Wed, 29 Jun 2022)

  Changed paths:
    M clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp
    M clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h

  Log Message:
  -----------
  [clang][dataflow] Use diagnosis API in optional checker

Followup to D127898. This patch updates `bugprone-unchecked-optional-access` to use the new `diagnoseCFG` function instead of just looking at the exit block.

A followup to this will update the optional model itself to use a noop lattice rather than redundantly computing the diagnostics in both phases of the analysis.

Reviewed By: ymandel, sgatev, gribozavr2, xazax.hun

Differential Revision: https://reviews.llvm.org/D128352