[all-commits] [llvm/llvm-project] dd48d3: Revert "[RISCV] Avoid changing etype for splat of ...

Philip Reames via All-commits all-commits at lists.llvm.org
Wed Jun 29 10:27:30 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd48d3ad0e5fff78e6e3a7fd8ca830624ccb8e33
      https://github.com/llvm/llvm-project/commit/dd48d3ad0e5fff78e6e3a7fd8ca830624ccb8e33
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2022-06-29 (Wed, 29 Jun 2022)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
    M llvm/test/CodeGen/RISCV/rvv/constant-folding-crash.ll
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-calling-conv.ll
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-fp-setcc.ll
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-fp2i.ll

  Log Message:
  -----------
  Revert "[RISCV] Avoid changing etype for splat of 0 or -1"

This reverts commit 755c84c62cda80b0acf51ccc5653fc6d64536f7e.  A bug was reported on the original review thread (https://reviews.llvm.org/D128006), and on inspection this patch is simply wrong.  It needs to be checking for VLInBytes, not MaxVL.  These happen to be the same when using AVL=VLMAX (which is quite common), but this does not fold when AVL != VLMAX.




More information about the All-commits mailing list