[all-commits] [llvm/llvm-project] 9d4a2b: [flang][test] Remove RUN COMMANDS/EXPECTED OUTPUT/...

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Jun 29 01:06:16 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d4a2baaa2c304066199ec6644da80aca7638dc6
      https://github.com/llvm/llvm-project/commit/9d4a2baaa2c304066199ec6644da80aca7638dc6
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-06-29 (Wed, 29 Jun 2022)

  Changed paths:
    M flang/test/Driver/code-gen-aarch64.f90
    M flang/test/Driver/code-gen-x86.f90
    M flang/test/Driver/dump-pft.f90
    M flang/test/Driver/emit-asm-aarch64.f90
    M flang/test/Driver/emit-asm-from-llvm-bc.ll
    M flang/test/Driver/emit-asm-from-llvm.ll
    M flang/test/Driver/emit-asm-from-mlir.mlir
    M flang/test/Driver/emit-asm-x86.f90
    M flang/test/Driver/emit-llvm-bc.f90
    M flang/test/Driver/emit-mlir.f90
    M flang/test/Driver/linker-flags.f90
    M flang/test/Driver/missing-triple.ll
    M flang/test/Driver/override-triple.ll

  Log Message:
  -----------
  [flang][test] Remove RUN COMMANDS/EXPECTED OUTPUT/INPUT markers from test/Driver

Uses of these markers are contrary to all other llvm-project subprojects
and carry no information for people who know the basics of a lit test.

I understand that there is an argument "this makes beginners get started
quickly" but I am unsure whether this is strong enough to deviate from
all other projects. https://llvm.org/docs/TestingGuide.html covers the
basics. Actually, some contributors were confused by the markers.

Differential Revision: https://reviews.llvm.org/D128763




More information about the All-commits mailing list