[all-commits] [llvm/llvm-project] b2671d: [mlir][spirv] Fix bitcast input order for UnifyAli...

Lei Zhang via All-commits all-commits at lists.llvm.org
Thu Jun 23 19:24:04 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b2671d8898e9f5aa66930ed17f9a3f108c6a9ab4
      https://github.com/llvm/llvm-project/commit/b2671d8898e9f5aa66930ed17f9a3f108c6a9ab4
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M mlir/lib/Dialect/SPIRV/Transforms/UnifyAliasedResourcePass.cpp
    M mlir/test/Dialect/SPIRV/Transforms/unify-aliased-resource.mlir

  Log Message:
  -----------
  [mlir][spirv] Fix bitcast input order for UnifyAliasedResourcePass

spv.bitcast from a vector to a scalar expects the lower-numbered
components of the the vector to map to the lower-ordered bits of
the scalar. That actually already matches how little endian stores
data in the memory. So we just need to read and push to the back
of the vector sequentially.

Reviewed By: hanchung

Differential Revision: https://reviews.llvm.org/D128473




More information about the All-commits mailing list