[all-commits] [llvm/llvm-project] 9846a1: [lldb] Remove an outdated comment. NFC.

Martin Storsjö via All-commits all-commits at lists.llvm.org
Wed Jun 22 06:12:37 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9846a1f2d4723a8c060370638bbd52360638d0fc
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-06-22 (Wed, 22 Jun 2022)

  Changed paths:
    M lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp

  Log Message:
  [lldb] Remove an outdated comment. NFC.

This comment became outdated in 053eb35651906e693906fad6c695fce11415ade7
(but was moved along); that commit moved the code and the comment
to a separate function, with a separate local variable
`num_of_bytes_read`. On error, the possibly garbage value is never
copied back to the caller's reference, thus the comment is no longer
relevant (and slightly confusing as is).

Differential Revision: https://reviews.llvm.org/D128226

More information about the All-commits mailing list