[all-commits] [llvm/llvm-project] 579279: Reland "[lld-macho] Show source information for un...

Daniel Bertalan via All-commits all-commits at lists.llvm.org
Tue Jun 21 15:51:24 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5792797c5b1316e19a7487fc016847f9a55a8f68
      https://github.com/llvm/llvm-project/commit/5792797c5b1316e19a7487fc016847f9a55a8f68
  Author: Daniel Bertalan <dani at danielbertalan.dev>
  Date:   2022-06-21 (Tue, 21 Jun 2022)

  Changed paths:
    M lld/ELF/InputFiles.cpp
    M lld/MachO/Dwarf.cpp
    M lld/MachO/Dwarf.h
    M lld/MachO/InputFiles.cpp
    M lld/MachO/InputFiles.h
    M lld/MachO/InputSection.cpp
    M lld/MachO/InputSection.h
    M lld/MachO/SymbolTable.cpp
    M lld/MachO/SyntheticSections.cpp
    M lld/MachO/SyntheticSections.h
    A lld/test/MachO/invalid/undef-debug.s

  Log Message:
  -----------
  Reland "[lld-macho] Show source information for undefined references"

The error used to look like this:

  ld64.lld: error: undefined symbol: _foo
  >>> referenced by /path/to/bar.o:(symbol _baz+0x4)

If DWARF line information is available, we now show where in the source
the references are coming from:

  ld64.lld: error: unreferenced symbol: _foo
  >>> referenced by: bar.cpp:42 (/path/to/bar.cpp:42)
  >>>                /path/to/bar.o:(symbol _baz+0x4)

The reland is identical to the first time this landed. The fix was in D128294.
This reverts commit 0cc7ad417585b3185c32e395cc5e6cf082a347af.

Differential Revision: https://reviews.llvm.org/D128184




More information about the All-commits mailing list