[all-commits] [llvm/llvm-project] d0d796: AMDGPU: Don't use branches to entry block in test

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Jun 21 12:37:25 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d0d796a40a7064dc4e66c73ff056275e8f40b1fa
      https://github.com/llvm/llvm-project/commit/d0d796a40a7064dc4e66c73ff056275e8f40b1fa
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-06-21 (Tue, 21 Jun 2022)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/optimize-negated-cond-exec-masking-wave32.mir
    M llvm/test/CodeGen/AMDGPU/optimize-negated-cond-exec-masking.mir

  Log Message:
  -----------
  AMDGPU: Don't use branches to entry block in test

This created a weird loop making the tested registers live out of the
block, which I don't think is relevant to the purpose of the
tests. This caused regressions when the validity queries are changed
to use tests based whether the use instruction was a kill. If the
register was live out for the loop, it was still live.

I guess we could still do this in a narrow case where the value loops
back, but that's most a pointlessly complex case to handle.


  Commit: 4cbbb35fcbb6ff54274502956387494293d23d01
      https://github.com/llvm/llvm-project/commit/4cbbb35fcbb6ff54274502956387494293d23d01
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-06-21 (Tue, 21 Jun 2022)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/optimize-exec-mask-pre-ra-loop-phi.mir
    M llvm/test/CodeGen/AMDGPU/undef-subreg-use-after-coalesce.mir

  Log Message:
  -----------
  AMDGPU: Regenerate test checks


Compare: https://github.com/llvm/llvm-project/compare/90254d524f29...4cbbb35fcbb6


More information about the All-commits mailing list