[all-commits] [llvm/llvm-project] ed63fc: [GlobalsModRef] Remove check for allocator calls

Nikita Popov via All-commits all-commits at lists.llvm.org
Tue Jun 21 05:24:33 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ed63fcb232b409310a33dcebe46f5f9c893223e3
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-06-21 (Tue, 21 Jun 2022)

  Changed paths:
    M llvm/lib/Analysis/GlobalsModRef.cpp

  Log Message:
  [GlobalsModRef] Remove check for allocator calls

As the FIXME already indicates, I don't see why this code would be
necessary. If there's a call to an allocator function, that should
get treated just like any other function call -- usually it will be
a declaration and handled conservatively based on memory attributes
only. There should be no need to explicitly force it to be modref.
No test failures either, so I think this is just dead code.

Differential Revision: https://reviews.llvm.org/D127273

More information about the All-commits mailing list