[all-commits] [llvm/llvm-project] 92c6ff: [clang][driver] Ensure we don't accumulate entries...

Jan Svoboda via All-commits all-commits at lists.llvm.org
Fri Jun 17 15:01:07 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 92c6ffa14cdeb3edd50b46d30c830698705db9f5
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M clang/lib/Driver/Driver.cpp
    M clang/test/Driver/compilation_database_multiarch.c

  Log Message:
  [clang][driver] Ensure we don't accumulate entries in -MJ files

Previously, each job would overwrite the -MJ file. This didn't quite work for Clang invocations with multiple architectures, which got fixed in D121997 by always appending to the -MJ file. That's not correct either, since the file would grow indefinitely on subsequent Clang invocations. This patch ensures the driver always removes the file before jobs fill it in by appending.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D128098

More information about the All-commits mailing list