[all-commits] [llvm/llvm-project] d30c02: [mlir] Split MLProgram global load and store to Gr...

Jacques Pienaar via All-commits all-commits at lists.llvm.org
Thu Jun 16 20:02:09 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d30c0221cf5aa36c079b7cc0d36fb89f7b32149b
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2022-06-16 (Thu, 16 Jun 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td
    M mlir/lib/Dialect/MLProgram/IR/MLProgramOps.cpp
    M mlir/test/Dialect/MLProgram/invalid.mlir
    M mlir/test/Dialect/MLProgram/ops.mlir

  Log Message:
  [mlir] Split MLProgram global load and store to Graph variants

* Split ops into X_graph variants as discussed;
* Remove tokens from non-Graph region variants and rely on side-effect
  modelling there while removing side-effect modelling from Graph
  variants and relying on explicit ordering there;
* Make tokens required to be produced by Graph variants - but kept
  explicit token type specification given previous discussion on this
  potentially being configurable in future;

This results in duplicating some code. I considered adding helper
functions but decided against adding an abstraction there early given
size of duplication and creating accidental coupling.

Differential Revision: https://reviews.llvm.org/D127813

More information about the All-commits mailing list