[all-commits] [llvm/llvm-project] f22db1: Fix StopInfoBreakpoint::ShouldNotify when a callba...

jimingham via All-commits all-commits at lists.llvm.org
Thu Jun 16 11:54:28 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f22db1fabfa165e9b18b1b49c78566d15f22bda1
  Author: Jim Ingham <jingham at apple.com>
  Date:   2022-06-16 (Thu, 16 Jun 2022)

  Changed paths:
    M lldb/source/Target/StopInfo.cpp

  Log Message:
  Fix StopInfoBreakpoint::ShouldNotify when a callback deletes the site we hit.

When we hit a breakpoint site all of whose owners are internal, we don't
broadcast that event to the public event queue.  However, we were checking
whether that was true in the ShouldNotify method, which gets run after the
breakpoint callbacks get run.  If the breakpoint callback deletes the site
we just hit, we no longer have the information to make that determination.

This patch just gathers the "was all internal" fact when the StopInfoBreakpoint
gets made, which happens before anyone has a chance to delete the site, and then
uses that cached value.

This bug was causing a couple of tests (including TestStopAtEntry.py) to fail
when using new the macOS Ventura dyld support.

Differential Revision: https://reviews.llvm.org/D127997

More information about the All-commits mailing list