[all-commits] [llvm/llvm-project] 838a57: Fix a bug introduced by the move of AddressRanges....

Greg Clayton via All-commits all-commits at lists.llvm.org
Thu Jun 16 10:51:03 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 838a57e1a5639a6fa9b8f8bdce5b6129a8c4302b
  Author: Greg Clayton <gclayton at fb.com>
  Date:   2022-06-16 (Thu, 16 Jun 2022)

  Changed paths:
    M llvm/lib/DebugInfo/GSYM/GsymCreator.cpp
    M llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp

  Log Message:
  Fix a bug introduced by the move of AddressRanges.h into ADT.

The bug was introduced when the AddressRange class was no longer able to modify the End address directly and the entire range of the .text address range that contained the trailing empty symbol was replaced. There was no unit test for this, so it wasn't caught. I fixed the bug and added a unit test for it.

The effects of this bug are serious as the AddressOffsetSize in the header would be incorrectly calculated and an invalid GSYM would be created.

Differential Revision: https://reviews.llvm.org/D127811

More information about the All-commits mailing list