[all-commits] [llvm/llvm-project] 7f24e5: [MLInliner] Don't inline call sites in unreachable...

Mircea Trofin via All-commits all-commits at lists.llvm.org
Thu Jun 16 09:14:43 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f24e574d434eb54675abb452b7e673302e7bd3d
      https://github.com/llvm/llvm-project/commit/7f24e574d434eb54675abb452b7e673302e7bd3d
  Author: Mircea Trofin <mtrofin at google.com>
  Date:   2022-06-16 (Thu, 16 Jun 2022)

  Changed paths:
    M llvm/include/llvm/Analysis/MLInlineAdvisor.h
    M llvm/lib/Analysis/MLInlineAdvisor.cpp
    A llvm/test/Transforms/Inline/ML/skip-unreachable.ll

  Log Message:
  -----------
  [MLInliner] Don't inline call sites in unreachable basic blocks

This requires DominatorTree be updated, which we do in the ml inliner
case, but not in the default case, and the cost of doing so is
noticeable to compile time for the latter[1]. So the patch only affects
the ML inliner.

[1] https://llvm-compile-time-tracker.com/compare.php?from=9fc0aa45e3312944431ba7e1ca0cec99c613992b&to=7af461b1ce0d9138211ef5f883f35d5b9ddf47be&stat=wall-time

Differential Revision: https://reviews.llvm.org/D127899




More information about the All-commits mailing list