[all-commits] [llvm/llvm-project] aaff3f: [mlgo] Fix accounting for SCC splits

Northbadge via All-commits all-commits at lists.llvm.org
Wed Jun 15 10:54:07 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aaff3fb6d5c3a3617034cbd6b2d78fcbe7874d39
  Author: Jin Xin Ng <njx at google.com>
  Date:   2022-06-15 (Wed, 15 Jun 2022)

  Changed paths:
    M llvm/include/llvm/Analysis/InlineAdvisor.h
    M llvm/include/llvm/Analysis/MLInlineAdvisor.h
    M llvm/lib/Analysis/MLInlineAdvisor.cpp
    M llvm/lib/Passes/PassRegistry.def
    M llvm/lib/Transforms/IPO/Inliner.cpp
    A llvm/test/Transforms/Inline/ML/scc-dead-accounting.ll

  Log Message:
  [mlgo] Fix accounting for SCC splits

Previously if the inliner split an SCC such that an empty one remained, the MLInlineAdvisor could potentially lose track of the EdgeCount if a subsequent CGSCC pass modified the calls of a function that was initially in the SCC pre-split. Saving the seen nodes in onPassEntry resolves this.

Reviewed By: mtrofin

Differential Revision: https://reviews.llvm.org/D127693

More information about the All-commits mailing list