[all-commits] [llvm/llvm-project] 7acc88: [OpenCL] Reword unknown extension pragma diagnostic

Sven van Haastregt via All-commits all-commits at lists.llvm.org
Wed Jun 15 02:55:14 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7acc88be0312c721bc082ed9934e381d297f4707
      https://github.com/llvm/llvm-project/commit/7acc88be0312c721bc082ed9934e381d297f4707
  Author: Sven van Haastregt <sven.vanhaastregt at arm.com>
  Date:   2022-06-15 (Wed, 15 Jun 2022)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/test/Headers/opencl-c-header.cl
    M clang/test/Parser/opencl-pragma.cl
    M clang/test/SemaOpenCL/extension-begin.cl
    M clang/test/SemaOpenCL/extension-version.cl

  Log Message:
  -----------
  [OpenCL] Reword unknown extension pragma diagnostic

For newer OpenCL extensions that do not require a pragma, such as
`cl_khr_subgroup_shuffle`, a user could still accidentally attempt to
use a pragma.  This would result in a warning
  "unknown OpenCL extension 'cl_khr_subgroup_shuffle' - ignoring"
which could be mistakenly interpreted as "clang does not support this
extension at all" instead of "clang does not require any pragma for
this extension".

Differential Revision: https://reviews.llvm.org/D126660




More information about the All-commits mailing list