[all-commits] [llvm/llvm-project] 0886ea: [mlir][Arith] Fix a use-after-free after rewriting...

Benjamin Kramer via All-commits all-commits at lists.llvm.org
Wed Jun 15 01:29:21 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0886ea902b1417acc8fa31b7c9fbaa6a1ab40e8f
      https://github.com/llvm/llvm-project/commit/0886ea902b1417acc8fa31b7c9fbaa6a1ab40e8f
  Author: Benjamin Kramer <benny.kra at googlemail.com>
  Date:   2022-06-15 (Wed, 15 Jun 2022)

  Changed paths:
    M mlir/lib/Dialect/Arithmetic/Transforms/UnsignedWhenEquivalent.cpp

  Log Message:
  -----------
  [mlir][Arith] Fix a use-after-free after rewriting ops to unsigned

Just short-circuit when a change was made, the erased value is invalid
after that. Found by asan.

This pass looks like it could use rewrite patterns instead which don't
have this issue, but let's fix the asan build first.




More information about the All-commits mailing list