[all-commits] [llvm/llvm-project] 9da697: Reland "[analyzer] Deprecate the unused 'analyzer-...

Balazs Benics via All-commits all-commits at lists.llvm.org
Tue Jun 14 01:23:13 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9da697e1bcefda6a75cd63a10679efe51333d7f9
  Author: Balazs Benics <balazs.benics at sigmatechnology.se>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M clang-tools-extra/clang-tidy/ClangTidy.cpp
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/Driver/Options.td
    M clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Frontend/CompilerInvocation.cpp
    M clang/test/Analysis/OSAtomic_mac.cpp
    M clang/test/Analysis/analyzer-stats.c
    M clang/test/Analysis/blocks.m
    M clang/test/Analysis/blocks.mm
    M clang/test/Analysis/deprecated-flags-and-options.cpp
    M clang/test/Analysis/misc-ps-arm.m
    M clang/test/Analysis/misc-ps-region-store.cpp
    M clang/test/Analysis/misc-ps-region-store.m
    M clang/test/Analysis/misc-ps-region-store.mm
    M clang/test/Analysis/objc-arc.m
    M clang/test/Analysis/unreachable-code-path.c

  Log Message:
  Reland "[analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag"

It was previously reverted by 8406839d1926486de900c7cabeea9f841bd3edf2.


This flag was introduced by
    commit 6818991d7165f68fe196922d9e5c6648dd57cc47
    Author: Ted Kremenek <kremenek at apple.com>
    Date:   Mon Dec 7 22:06:12 2009 +0000

  Add clang-cc option '-analyzer-opt-analyze-nested-blocks' to treat
  block literals as an entry point for analyzer checks.

The last reference was removed by this commit:

    commit 5c32dfc5fb1cfcff8ae3671284e17daa8da3a188
    Author: Anna Zaks <ganna at apple.com>
    Date:   Fri Dec 21 01:19:15 2012 +0000

  [analyzer] Add blocks and ObjC messages to the call graph.
  This paves the road for constructing a better function dependency graph.
  If we analyze a function before the functions it calls and inlines,
  there is more opportunity for optimization.
  Note, we add call edges to the called methods that correspond to
  function definitions (declarations with bodies).

Consequently, we should remove this dead flag.
However, this arises a couple of burning questions.
 - Should the `cc1` frontend still accept this flag - to keep
   tools/users passing this flag directly to `cc1` (which is unsupported,
   unadvertised) working.
 - If we should remain backward compatible, how long?
 - How can we get rid of deprecated and obsolete flags at some point?

Reviewed By: martong

Differential Revision: https://reviews.llvm.org/D126067

More information about the All-commits mailing list