[all-commits] [llvm/llvm-project] a370a4: [flang] Avoid raising a TODO in fir.boxproc rewrit...

jeanPerier via All-commits all-commits at lists.llvm.org
Mon Jun 13 08:37:15 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a370a4ffce083a218daed4de468853c1db7e3a1e
  Author: jeanPerier <jeanPerier at users.noreply.github.com>
  Date:   2022-06-13 (Mon, 13 Jun 2022)

  Changed paths:
    M flang/lib/Optimizer/CodeGen/BoxedProcedure.cpp
    A flang/test/Fir/boxproc-2.fir

  Log Message:
  [flang] Avoid raising a TODO in fir.boxproc rewrite when not needed (#1560)

The pass was raising TODOs when a function both had a fir.boxproc<> argument
and a fir.type<> argument (even if the fir.type<> did not contain a
fir.boxproc itself).

Prevent the TODO from firing when a fir.type<> does not actually contain
a fir.boxproc. Add the location for the remaining TODO (it will be
needed when procedure pointer components are supported in lowering).

FYI, I actually tried to just implement the TODO, but I there is  a funny
issue. When creating the new fir::RecordType, since the name and context
are the same as the type being translated, fir::RecordType:get just
returns the existing type, and there is no way to change it (finalize()
does nothing since it is already finalized). So this will require to add
the ability to mutate the existing type, and I am not sure what are the
MLIR constraints here, so I escaped and left the TODO for that case.

This patch is part of the upstreaming effort from fir-dev branch.

Reviewed By: jeanPerier, PeteSteinfeld

Differential Revision: https://reviews.llvm.org/D127633

Co-authored-by: Jean Perier <jperier at nvidia.com>

More information about the All-commits mailing list