[all-commits] [llvm/llvm-project] 2a3288: [InstSimplify] Update GEP test to use opaque point...

Nikita Popov via All-commits all-commits at lists.llvm.org
Mon Jun 13 01:46:10 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2a3288776c940669fed430c3984b91e61ab0f015
      https://github.com/llvm/llvm-project/commit/2a3288776c940669fed430c3984b91e61ab0f015
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-06-13 (Mon, 13 Jun 2022)

  Changed paths:
    M llvm/test/Transforms/InstSimplify/ConstProp/gep.ll

  Log Message:
  -----------
  [InstSimplify] Update GEP test to use opaque pointers (NFC)

With opaque pointers, we end up merging these GEPs and dropping
the inrange attribute (in the last two cases). This did not happen
previously, because typed pointers use less powerful GEP folding logic.

I'm a bit unsure whether this is something we need to be concerned
about or not. I believe that generally our stance is that we should
perform folds even if this requires losing poison-generating flags
like inrange.

We can either a) accept this as-is, b) try to inhibit folding if it
requires dropping inrange or c) try to fold to poison if we know
that inrange is going to be violated.

For now, we accept it as-is.

Differential Revision: https://reviews.llvm.org/D127503




More information about the All-commits mailing list